Repository navigation
fix: reject units in StateSet builder - #2635
2748109647 wants to merge 2 commits into
Conversation
Signed-off-by: Alpha <2748109647@qq.com>
|
Run |
Signed-off-by: Alpha <2748109647@qq.com>
|
|
Done in commit 60a51f1 (60a51f1). I reviewed the generated diff; it records the new public The documented Maven API-diff reactor completed successfully across all 30 modules with |
@fstab
Fixes #2632.
StateSet.Builderinherited the genericunit(...)setter, so it accepted a non-null unit while building and only failed later duringcollect(). Override the setter to reject non-null units immediately, consistent withInfo.Builder, and add a regression test.Validation:
mvnw.cmd test -pl prometheus-metrics-core -am -Dtest=StateSetTest -Dsurefire.failIfNoSpecifiedTests=false -Dcoverage.skip=true— 5 tests passed; reactor build succeeded.mvnw.cmd install -DskipTests -DskipITs -Dcoverage.skip=true— all 56 modules built successfully.mise run lint:fixapplied formatting. Checkstyle could not run locally because its downloaded Windows executable reported an incompatible binary.docker.mirrors.ustc.edu.cnregistry mirror did not resolve when pullingtestcontainers/ryuk:0.12.0; those checks remain unverified.